Controll delayed startup/restart for kubelet/etcd

In order to mitigate sporadic data races in etcd
(publish error: etcdserver: request timed out"):
- Add etcd_start_delay and kubelet_start_delay (defaults to a 5 sec.)
- Increase default start sleep times to foo_start_delay from a 1 sec.
- Add restart sleeping as well.
- Add missing start sleep commands as appropriate.

Closes: https://github.com/kubespray/kargo/issues/342

Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>

roles/dnsmasq/handlers/main.yml

@@ -30,5 +30,6 @@
   service:
     name: kubelet
     state: restarted
+    sleep: "{{ kubelet_start_delay|int }}"
   when: "{{ inventory_hostname in groups['kube-master'] }}"
   ignore_errors: true

roles/etcd/handlers/main.yml

@@ -28,10 +28,12 @@
   service:
     name: etcd
     state: restarted
+    sleep: "{{ etcd_start_delay|int }}"
   when: is_etcd_master
 
 - name: reload etcd-proxy
   service:
     name: etcd-proxy
     state: restarted
+    sleep: "{{ etcd_start_delay|int }}"
   when: is_etcd_proxy

roles/etcd/templates/deb-etcd-docker.initd.j2

@@ -50,7 +50,7 @@ do_status()
 do_start()
 {
     {{ docker_bin_dir | default("/usr/bin") }}/docker rm -f {{ etcd_member_name | default("etcd-proxy") }} &>/dev/null || true
-    sleep 1
+    sleep {{ etcd_start_delay }}
     start-stop-daemon --background --start --quiet --make-pidfile --pidfile $PID --user $DAEMON_USER --exec $DAEMON -- \
         $DAEMON_ARGS \
         || return 2

roles/etcd/templates/deb-etcd-host.initd.j2

@@ -41,6 +41,7 @@ do_status()
 #
 do_start()
 {
+    sleep {{ etcd_start_delay }}
     start-stop-daemon --background --start --quiet --make-pidfile --pidfile $PID --user $DAEMON_USER --exec $DAEMON -- \
         $DAEMON_ARGS \
         || return 2

roles/etcd/templates/deb-etcd-proxy-docker.initd.j2

@@ -51,7 +51,7 @@ do_status()
 do_start()
 {
     {{ docker_bin_dir | default("/usr/bin") }}/docker rm -f {{ etcd_proxy_member_name | default("etcd-proxy") }} &>/dev/null || true
-    sleep 1
+    sleep {{ etcd_start_delay }}
     start-stop-daemon --background --start --quiet --make-pidfile --pidfile $PID --user $DAEMON_USER --exec $DAEMON -- \
         $DAEMON_ARGS \
         || return 2

roles/etcd/templates/deb-etcd-proxy-host.initd.j2

@@ -42,6 +42,7 @@ do_status()
 #
 do_start()
 {
+    sleep {{ etcd_start_delay }}
     start-stop-daemon --background --start --quiet --make-pidfile --pidfile $PID --user $DAEMON_USER --exec $DAEMON -- \
         $DAEMON_ARGS \
         || return 2

roles/etcd/templates/etcd-docker.service.j2

@@ -23,6 +23,8 @@ ExecReload={{ docker_bin_dir | default("/usr/bin") }}/docker restart {{ etcd_mem
 ExecStop={{ docker_bin_dir | default("/usr/bin") }}/docker stop {{ etcd_member_name | default("etcd-proxy") }}
 Restart=always
 RestartSec=15s
+OnStartupSec={{ etcd_start_delay }}
+OnBootSec={{ etcd_start_delay }}
 
 [Install]
 WantedBy=multi-user.target

roles/etcd/templates/etcd-host.service.j2

@@ -11,6 +11,8 @@ NotifyAccess=all
 Restart=always
 RestartSec=10s
 LimitNOFILE=40000
+OnStartupSec={{ etcd_start_delay }}
+OnBootSec={{ etcd_start_delay }}
 
 [Install]
 WantedBy=multi-user.target

roles/etcd/templates/etcd-proxy-docker.service.j2

@@ -23,6 +23,8 @@ ExecReload={{ docker_bin_dir | default("/usr/bin") }}/docker restart {{ etcd_pro
 ExecStop={{ docker_bin_dir | default("/usr/bin") }}/docker stop {{ etcd_proxy_member_name | default("etcd-proxy") }}
 Restart=always
 RestartSec=15s
+OnStartupSec={{ etcd_start_delay }}
+OnBootSec={{ etcd_start_delay }}
 
 [Install]
 WantedBy=multi-user.target

roles/etcd/templates/etcd-proxy-host.service.j2

@@ -14,6 +14,8 @@ NotifyAccess=all
 Restart=always
 RestartSec=10s
 LimitNOFILE=40000
+OnStartupSec={{ etcd_start_delay }}
+OnBootSec={{ etcd_start_delay }}
 
 [Install]
 WantedBy=multi-user.target

roles/kubernetes/master/handlers/main.yml

@@ -21,6 +21,7 @@
   service:
     name: kubelet
     state: restarted
+    sleep: "{{ kubelet_start_delay|int }}"
 
 - name: Master | wait for kube-scheduler
   uri: url=http://localhost:10251/healthz

roles/kubernetes/node/handlers/main.yml

@@ -13,3 +13,4 @@
   service:
     name: kubelet
     state: restarted
+    sleep: "{{ kubelet_start_delay|int }}"

roles/kubernetes/node/templates/deb-kubelet.initd.j2

@@ -40,7 +40,7 @@ DAEMON_USER=root
 do_start()
 {
         /usr/bin/docker rm -f kubelet &>/dev/null || true
-        sleep 1
+        sleep {{ kubelet_start_delay }}
         # Return
         #   0 if daemon has been started
         #   1 if daemon was already running

roles/kubernetes/node/templates/kubelet-container.j2

@@ -1,4 +1,5 @@
 #!/bin/bash
+sleep {{ kubelet_start_delay }}
 /usr/bin/docker run --privileged --rm \
 --net=host --pid=host --name=kubelet \
 -v /etc/cni:/etc/cni:ro \

roles/kubernetes/node/templates/kubelet.service.j2

@@ -28,6 +28,8 @@ ExecStartPre=-/usr/bin/docker rm -f kubelet
 ExecReload=/usr/bin/docker restart kubelet
 Restart=always
 RestartSec=10s
+OnStartupSec={{ kubelet_start_delay }}
+OnBootSec={{ kubelet_start_delay }}
 
 [Install]
 WantedBy=multi-user.target

roles/kubernetes/node/templates/rh-kubelet.initd.j2

@@ -44,6 +44,7 @@ start() {
     if ! [ -f $pidfile ]; then
         printf "Starting $prog:\t"
         echo "\n$(date)\n" >> $logfile
+        sleep {{ kubelet_start_delay }}
         $exec $DAEMON_ARGS &>> $logfile &
         pid=$!
         echo $pid >> $pidfile

roles/kubernetes/preinstall/defaults/main.yml

@@ -1,6 +1,10 @@
 ---
 run_gitinfos: false
 
+# Controll delayed startup/restart for services, in seconds
+etcd_start_delay: 5
+kubelet_start_delay: 5
+
 # This directory is where all the additional scripts go
 # that Kubernetes normally puts in /srv/kubernetes.
 # This puts them in a sane location

roles/network_plugin/flannel/handlers/main.yml

@@ -8,3 +8,4 @@
   service:
     name: kubelet
     state: restarted
+    sleep: "{{ kubelet_start_delay|int }}"