Split download container task for delegate and non-delegate modes (#2077)
Ansible cannot seem to handle omitting delegate_to since v2.4.0.0. Possibly related: https://github.com/ansible/ansible/issues/30760
This commit is contained in:
parent
39ce1bd8be
commit
b135bcb9d9
1 changed files with 19 additions and 4 deletions
|
@ -10,16 +10,31 @@
|
||||||
tags:
|
tags:
|
||||||
- facts
|
- facts
|
||||||
|
|
||||||
- name: container_download | Download containers if pull is required or told to always pull
|
# FIXME(mattymo): In Ansible 2.4 omitting download delegate is broken. Move back
|
||||||
|
# to one task in the future.
|
||||||
|
- name: container_download | Download containers if pull is required or told to always pull (delegate)
|
||||||
command: "{{ docker_bin_dir }}/docker pull {{ pull_args }}"
|
command: "{{ docker_bin_dir }}/docker pull {{ pull_args }}"
|
||||||
register: pull_task_result
|
register: pull_task_result
|
||||||
until: pull_task_result|succeeded
|
until: pull_task_result|succeeded
|
||||||
retries: 4
|
retries: 4
|
||||||
delay: "{{ retry_stagger | random + 3 }}"
|
delay: "{{ retry_stagger | random + 3 }}"
|
||||||
when:
|
when:
|
||||||
|
- download_run_once
|
||||||
|
- download.enabled
|
||||||
|
- download.container
|
||||||
|
- pull_required|default(download_always_pull)
|
||||||
|
delegate_to: "{{ download_delegate }}"
|
||||||
|
delegate_facts: yes
|
||||||
|
run_once: yes
|
||||||
|
|
||||||
|
- name: container_download | Download containers if pull is required or told to always pull (all nodes)
|
||||||
|
command: "{{ docker_bin_dir }}/docker pull {{ pull_args }}"
|
||||||
|
register: pull_task_result
|
||||||
|
until: pull_task_result|succeeded
|
||||||
|
retries: 4
|
||||||
|
delay: "{{ retry_stagger | random + 3 }}"
|
||||||
|
when:
|
||||||
|
- not download_run_once
|
||||||
- download.enabled
|
- download.enabled
|
||||||
- download.container
|
- download.container
|
||||||
- pull_required|default(download_always_pull)
|
- pull_required|default(download_always_pull)
|
||||||
delegate_to: "{{ download_delegate if download_run_once or omit }}"
|
|
||||||
delegate_facts: no
|
|
||||||
run_once: "{{ download_run_once }}"
|
|
||||||
|
|
Loading…
Reference in a new issue