From b218e17f44fcd331e272b8f46aa8dddfa7be9317 Mon Sep 17 00:00:00 2001
From: Maxime Guyot <Miouge1@users.noreply.github.com>
Date: Thu, 18 Apr 2019 10:34:08 +0200
Subject: [PATCH] ansible-lint: E403 Package installs should not use latest
 (#4500)

---
 .ansible-lint                                 |  1 -
 .../kvm-setup/roles/kvm-setup/tasks/main.yml  | 20 ++-----------------
 .../tasks/0120-growpart-azure-centos-7.yml    |  2 +-
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/.ansible-lint b/.ansible-lint
index 547441059..91d8f45e5 100644
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -14,7 +14,6 @@ skip_list:
   - '303'
   - '305'
   - '306'
-  - '403'
   - '404'
   - '502'
   - '503'
diff --git a/contrib/kvm-setup/roles/kvm-setup/tasks/main.yml b/contrib/kvm-setup/roles/kvm-setup/tasks/main.yml
index e1df16ad2..543fee5a0 100644
--- a/contrib/kvm-setup/roles/kvm-setup/tasks/main.yml
+++ b/contrib/kvm-setup/roles/kvm-setup/tasks/main.yml
@@ -1,15 +1,9 @@
 ---
 
-- name: Upgrade all packages to the latest version (yum)
-  yum:
-    name: '*'
-    state: latest
-  when: ansible_os_family == "RedHat"
-
 - name: Install required packages
   yum:
     name: "{{ item }}"
-    state: latest
+    state: present
   with_items:
     - bind-utils
     - ntp
@@ -21,23 +15,13 @@
     update_cache: yes
     cache_valid_time: 3600
     name: "{{ item }}"
-    state: latest
+    state: present
     install_recommends: no
   with_items:
     - dnsutils
     - ntp
   when: ansible_os_family == "Debian"
 
-- name: Upgrade all packages to the latest version (apt)
-  shell: apt-get -o \
-       Dpkg::Options::=--force-confdef -o \
-       Dpkg::Options::=--force-confold -q -y \
-       dist-upgrade
-  environment:
-    DEBIAN_FRONTEND: noninteractive
-  when: ansible_os_family == "Debian"
-
-
 # Create deployment user if required
 - include: user.yml
   when: k8s_deployment_user is defined
diff --git a/roles/kubernetes/preinstall/tasks/0120-growpart-azure-centos-7.yml b/roles/kubernetes/preinstall/tasks/0120-growpart-azure-centos-7.yml
index 3e737fea3..b00c576ed 100644
--- a/roles/kubernetes/preinstall/tasks/0120-growpart-azure-centos-7.yml
+++ b/roles/kubernetes/preinstall/tasks/0120-growpart-azure-centos-7.yml
@@ -5,7 +5,7 @@
 - name: install growpart
   package:
     name: cloud-utils-growpart
-    state: latest
+    state: present
 
 - name: check if growpart needs to be run
   command: growpart -N /dev/sda 1