From b4aaa7b9088691750a62d29e650e9e30c32a4f13 Mon Sep 17 00:00:00 2001 From: Gabor Lekeny Date: Tue, 26 Feb 2019 04:56:23 +0100 Subject: [PATCH] Speed up tasks (#4278) * fact gathering should run only once per node * eliminate ansible version check, it is at the beginning of each playbook --- cluster.yml | 5 +++-- roles/kubernetes/preinstall/tasks/0020-verify-settings.yml | 6 ------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/cluster.yml b/cluster.yml index 9bdb9000c..e93983c18 100644 --- a/cluster.yml +++ b/cluster.yml @@ -35,13 +35,14 @@ any_errors_fatal: "{{ any_errors_fatal | default(true) }}" vars: ansible_ssh_pipelining: true - gather_facts: true + gather_facts: false pre_tasks: - name: gather facts from all instances setup: delegate_to: "{{item}}" - delegate_facts: True + delegate_facts: true with_items: "{{ groups['k8s-cluster'] + groups['etcd'] + groups['calico-rr']|default([]) }}" + run_once: true - hosts: k8s-cluster:etcd:calico-rr any_errors_fatal: "{{ any_errors_fatal | default(true) }}" diff --git a/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml b/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml index 8ec6cc111..a6e86e40b 100644 --- a/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml +++ b/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml @@ -1,10 +1,4 @@ --- -- name: Stop if ansible version is too low - assert: - that: - - ansible_version.full is version('2.3.0', '>=') - run_once: yes - - name: Stop if either kube-master, kube-node or etcd is empty assert: that: groups.get('{{ item }}')