missing "check_mode: no"s for several read-only tasks (#8584)

this is not complete -- there are almost certainly more instances of
this issue
This commit is contained in:
Tom Janson 2022-03-02 18:29:14 +01:00 committed by GitHub
parent 672e47a7eb
commit ddef7e1139
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 0 deletions

View file

@ -19,6 +19,7 @@
command: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial"
register: "etcd_client_cert_serial_result"
changed_when: false
check_mode: no
when:
- inventory_hostname in groups['k8s_cluster']|union(groups['calico_rr']|default([]))|unique|sort
tags:

View file

@ -4,6 +4,7 @@
shell: "docker info | grep 'Cgroup Driver' | awk -F': ' '{ print $2; }'"
register: docker_cgroup_driver_result
changed_when: false
check_mode: no
- name: set kubelet_cgroup_driver_detected fact for docker
set_fact:

View file

@ -52,6 +52,7 @@
register: modinfo_br_netfilter
failed_when: modinfo_br_netfilter.rc not in [0, 1]
changed_when: false
check_mode: no
- name: Verify br_netfilter module path exists
file:
@ -77,6 +78,7 @@
command: "sysctl net.bridge.bridge-nf-call-iptables"
failed_when: false
changed_when: false
check_mode: no
register: sysctl_bridge_nf_call_iptables
- name: Enable bridge-nf-call tables

View file

@ -11,6 +11,7 @@
executable: /bin/bash
failed_when: false
changed_when: false
check_mode: no
register: kubelet_container_check
- name: "Pre-upgrade | copy /var/lib/cni from kubelet"

View file

@ -41,6 +41,7 @@
command: calicoctl.sh get ipPool {{ calico_pool_name }} -o json
failed_when: False
changed_when: False
check_mode: no
register: calico
run_once: True
delegate_to: "{{ groups['kube_control_plane'][0] }}"