missing "check_mode: no"s for several read-only tasks (#8584)
this is not complete -- there are almost certainly more instances of this issue
This commit is contained in:
parent
672e47a7eb
commit
ddef7e1139
5 changed files with 6 additions and 0 deletions
|
@ -19,6 +19,7 @@
|
||||||
command: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial"
|
command: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial"
|
||||||
register: "etcd_client_cert_serial_result"
|
register: "etcd_client_cert_serial_result"
|
||||||
changed_when: false
|
changed_when: false
|
||||||
|
check_mode: no
|
||||||
when:
|
when:
|
||||||
- inventory_hostname in groups['k8s_cluster']|union(groups['calico_rr']|default([]))|unique|sort
|
- inventory_hostname in groups['k8s_cluster']|union(groups['calico_rr']|default([]))|unique|sort
|
||||||
tags:
|
tags:
|
||||||
|
|
|
@ -4,6 +4,7 @@
|
||||||
shell: "docker info | grep 'Cgroup Driver' | awk -F': ' '{ print $2; }'"
|
shell: "docker info | grep 'Cgroup Driver' | awk -F': ' '{ print $2; }'"
|
||||||
register: docker_cgroup_driver_result
|
register: docker_cgroup_driver_result
|
||||||
changed_when: false
|
changed_when: false
|
||||||
|
check_mode: no
|
||||||
|
|
||||||
- name: set kubelet_cgroup_driver_detected fact for docker
|
- name: set kubelet_cgroup_driver_detected fact for docker
|
||||||
set_fact:
|
set_fact:
|
||||||
|
|
|
@ -52,6 +52,7 @@
|
||||||
register: modinfo_br_netfilter
|
register: modinfo_br_netfilter
|
||||||
failed_when: modinfo_br_netfilter.rc not in [0, 1]
|
failed_when: modinfo_br_netfilter.rc not in [0, 1]
|
||||||
changed_when: false
|
changed_when: false
|
||||||
|
check_mode: no
|
||||||
|
|
||||||
- name: Verify br_netfilter module path exists
|
- name: Verify br_netfilter module path exists
|
||||||
file:
|
file:
|
||||||
|
@ -77,6 +78,7 @@
|
||||||
command: "sysctl net.bridge.bridge-nf-call-iptables"
|
command: "sysctl net.bridge.bridge-nf-call-iptables"
|
||||||
failed_when: false
|
failed_when: false
|
||||||
changed_when: false
|
changed_when: false
|
||||||
|
check_mode: no
|
||||||
register: sysctl_bridge_nf_call_iptables
|
register: sysctl_bridge_nf_call_iptables
|
||||||
|
|
||||||
- name: Enable bridge-nf-call tables
|
- name: Enable bridge-nf-call tables
|
||||||
|
|
|
@ -11,6 +11,7 @@
|
||||||
executable: /bin/bash
|
executable: /bin/bash
|
||||||
failed_when: false
|
failed_when: false
|
||||||
changed_when: false
|
changed_when: false
|
||||||
|
check_mode: no
|
||||||
register: kubelet_container_check
|
register: kubelet_container_check
|
||||||
|
|
||||||
- name: "Pre-upgrade | copy /var/lib/cni from kubelet"
|
- name: "Pre-upgrade | copy /var/lib/cni from kubelet"
|
||||||
|
|
|
@ -41,6 +41,7 @@
|
||||||
command: calicoctl.sh get ipPool {{ calico_pool_name }} -o json
|
command: calicoctl.sh get ipPool {{ calico_pool_name }} -o json
|
||||||
failed_when: False
|
failed_when: False
|
||||||
changed_when: False
|
changed_when: False
|
||||||
|
check_mode: no
|
||||||
register: calico
|
register: calico
|
||||||
run_once: True
|
run_once: True
|
||||||
delegate_to: "{{ groups['kube_control_plane'][0] }}"
|
delegate_to: "{{ groups['kube_control_plane'][0] }}"
|
||||||
|
|
Loading…
Reference in a new issue