Charavane/gridfinity-rebuilt-openscad
1
0
Fork 1
mirror of https://github.com/kennetek/gridfinity-rebuilt-openscad.git synced 2024-10-18 15:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #183 from jpypi/fix-cylinder-cuts

Browse source 
Fix cylinder depth, chamfer, and function formatting
This commit is contained in:
Arthur Moore 2024-10-13 15:40:42 -04:00 committed by GitHub
commit 4536f90824
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gridfinity-rebuilt-utility.scad
View file

@ -96,6 +96,13 @@ module cutCylinders(n_divx=1, n_divy=1, cylinder_diameter=1, cylinder_height=1,
? [90, 0, 0]
: [0, 0, 0];
// When oriented vertically along the z axis, half of the cutting cylinder is in the air
// When oriented along the x or y axes, the entire height of the cylinder is cut out
cylinder_height = (orientation == 2) ? cylinder_height * 2 : cylinder_height;
// Chamfer is only enabled for vertical, since it doesn't make sense in other orientations
chamfer = (orientation == 2) ? chamfer : 0;
gridx_mm = $gxx * l_grid;
gridy_mm = $gyy * l_grid;
padding = 2;
@ -109,7 +116,7 @@ module cutCylinders(n_divx=1, n_divy=1, cylinder_diameter=1, cylinder_height=1,
pattern_linear(x=n_divx, y=n_divy, sx=(gridx_mm - padding) / n_divx, sy=(gridy_mm - padding) / n_divy)
rotate(rotation)
union() {
cylinder(d=cylinder_diameter, h=cylinder_height*2, center=true);
cylinder(d=cylinder_diameter, h=cylinder_height, center=true);
if (chamfer > 0) {
translate([0, 0, -chamfer]) cylinder(d1=cylinder_diameter, d2=cylinder_diameter + 4 * chamfer, h=2 * chamfer);
}