Commit graph

10 commits

Author SHA1 Message Date
Joseph Carter
d1f766d2b8 Fix umount_image (#22)
* export-noobs/prerun.sh: Use nested mountpoint

While it seems elegant and intuitive to use separate bootfs and rootfs
mountpoints for compressing the partitions, doing so violates a
precondition of unmount_image that they be mounted as a tree.  This
causes the image to not be properly unmounted and detached.  A better
solution might be to pack up the previous stage's chroot directory, but
that rework can wait for the time being.

scripts/common.sh: Output device name correctly

A misplaced ) in unmount_image caused the loop device to be incorrectly
identified, resulting in a fair bit of chaos trying to unmount other
filesystems on /dev/mapper devices.  Such as / on a LUKS-encrypted
installation, for example.  The unmount will fail as it should and
build.sh will abort the build without any cleanup.  Best to avoid that.

These changes close RPi-Distro/pi-gen#19
2016-10-06 10:14:43 +01:00
Serge Schneider
a07b9c5c4e dependencies_check: add missing bracket (closes issue #17). 2016-09-15 13:16:13 +10:00
Joseph Carter
0245cbb958 Dependency checks + important bugfix (#16) 2016-09-14 20:07:52 +10:00
Joseph Carter
abc3e45727 build.sh: Support comments in package files (#14)
* build.sh: Support comments in package files

This patch allows the use of hash comments inside patch files.  It's a
little ugly, but it strips comments and collapses all whitespace down to
single space characters between package names.  It handles comments
anywhere in a line, as well.

Was unsure if \ continuation of the long sed line or the inclusion of a
couple of lines of comments explaining what the sed expressions are
doing would be appreciated, so didn't include them in this patch.

* build.sh: whitespace fix

* build.sh: Use sed script for packages files

Broke the sed expressions out of build.sh and put them their own
documented sed script.  This greatly improves readability and avoids
build.sh getting messier.

Broke the substitution command into two separate subs.  The first just
deletes comments, and the second collapses all whitespace into a single
space.  This too is easier to read, and catches a couple of edge cases
that would result it not all whitespace being collapsed.  The result may
still have (one) leading and/or trailing space, which is acceptable.
2016-09-08 06:32:36 +10:00
Serge Schneider
cc5a65723c Add NOOBS export support 2016-05-27 11:54:56 +01:00
Serge Schneider
b61c63db8f common: Fix issue date 2016-05-05 14:55:53 +01:00
Serge Schneider
aca321fd70 Various fixes 2016-05-04 19:52:13 +01:00
Teguh Sobirin
612c1a73f1 Add missing /dev/pts
Missing /dev/pts causing "Can not write log, openpty() failed (/dev/pts not mounted?)"
2016-04-27 10:33:04 +01:00
Serge Schneider
2701f10c90 Initial build script 2016-04-11 07:21:07 +01:00
Serge Schneider
25b7d54af5 Setup initial layout 2016-04-08 03:32:06 +01:00