From 3d2f9b9e54d519c68666a804b68f1b3977e5f54e Mon Sep 17 00:00:00 2001 From: Matthias Pigulla Date: Wed, 19 Oct 2022 10:26:23 +0000 Subject: [PATCH] Express logging flag in a "positive" way, not as "do not log" --- action.yml | 4 ++-- dist/index.js | 4 ++-- index.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/action.yml b/action.yml index 838515a..e48f1e6 100644 --- a/action.yml +++ b/action.yml @@ -6,10 +6,10 @@ inputs: required: true ssh-auth-sock: description: 'Where to place the SSH Agent auth socket' - dont-log-public-key: + log-public-key: description: 'Whether or not to log public key fingerprints' required: false - default: false + default: true runs: using: 'node12' main: 'dist/index.js' diff --git a/dist/index.js b/dist/index.js index 1dbdaf9..46f6582 100644 --- a/dist/index.js +++ b/dist/index.js @@ -326,7 +326,7 @@ const { home, sshAgent, sshAdd } = __webpack_require__(972); try { const privateKey = core.getInput('ssh-private-key'); - const dontLogPublicKey = core.getBooleanInput('dont-log-public-key', {default: false}); + const logPublicKey = core.getBooleanInput('log-public-key', {default: true}); if (!privateKey) { core.setFailed("The ssh-private-key argument is empty. Maybe the secret has not been configured, or you are using a wrong secret name in your workflow file."); @@ -375,7 +375,7 @@ try { const parts = key.match(/\bgithub\.com[:/]([_.a-z0-9-]+\/[_.a-z0-9-]+)/i); if (!parts) { - if (!dontLogPublicKey) { + if (logPublicKey) { console.log(`Comment for (public) key '${key}' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.`); } return; diff --git a/index.js b/index.js index c8ad8aa..5dbc831 100644 --- a/index.js +++ b/index.js @@ -6,7 +6,7 @@ const { home, sshAgent, sshAdd } = require('./paths.js'); try { const privateKey = core.getInput('ssh-private-key'); - const dontLogPublicKey = core.getBooleanInput('dont-log-public-key', {default: false}); + const logPublicKey = core.getBooleanInput('log-public-key', {default: true}); if (!privateKey) { core.setFailed("The ssh-private-key argument is empty. Maybe the secret has not been configured, or you are using a wrong secret name in your workflow file."); @@ -55,7 +55,7 @@ try { const parts = key.match(/\bgithub\.com[:/]([_.a-z0-9-]+\/[_.a-z0-9-]+)/i); if (!parts) { - if (!dontLogPublicKey) { + if (logPublicKey) { console.log(`Comment for (public) key '${key}' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.`); } return;