Use execFileSync to clean up (#80)

execSync just started a second ssh-agent. `['-k']` argument was
treated as options, it didn't have `stdio` set, so stdio was piped and
returned (and ignored).
This commit is contained in:
Maciej Pasternacki 2021-06-11 15:17:22 +02:00 committed by GitHub
parent 81d965f2bd
commit a45226bfaf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 6 deletions

View file

@ -1,12 +1,11 @@
const core = require('@actions/core'); const core = require('@actions/core');
const { execSync } = require('child_process'); const { execFileSync } = require('child_process');
const { sshAgent } = require('./paths.js'); const { sshAgent } = require('./paths.js');
try { try {
// Kill the started SSH agent // Kill the started SSH agent
console.log('Stopping SSH agent'); console.log('Stopping SSH agent');
execSync(sshAgent, ['-k'], { stdio: 'inherit' }); execFileSync(sshAgent, ['-k'], { stdio: 'inherit' });
} catch (error) { } catch (error) {
console.log(error.message); console.log(error.message);
console.log('Error stopping the SSH agent, proceeding anyway'); console.log('Error stopping the SSH agent, proceeding anyway');

5
dist/cleanup.js vendored
View file

@ -123,14 +123,13 @@ module.exports = require("child_process");
/***/ (function(__unusedmodule, __unusedexports, __webpack_require__) { /***/ (function(__unusedmodule, __unusedexports, __webpack_require__) {
const core = __webpack_require__(470); const core = __webpack_require__(470);
const { execSync } = __webpack_require__(129); const { execFileSync } = __webpack_require__(129);
const { sshAgent } = __webpack_require__(972); const { sshAgent } = __webpack_require__(972);
try { try {
// Kill the started SSH agent // Kill the started SSH agent
console.log('Stopping SSH agent'); console.log('Stopping SSH agent');
execSync(sshAgent, ['-k'], { stdio: 'inherit' }); execFileSync(sshAgent, ['-k'], { stdio: 'inherit' });
} catch (error) { } catch (error) {
console.log(error.message); console.log(error.message);
console.log('Error stopping the SSH agent, proceeding anyway'); console.log('Error stopping the SSH agent, proceeding anyway');