NixiN/ssh-agent-action

Fork 0

mirror of https://github.com/webfactory/ssh-agent.git synced 2024-10-16 08:17:25 +00:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Matthias Pigulla	8a9e20a586	Fix path to `git` binary on Windows runners (#140 ) This PR fixes an apparently wrong path to the `git` binary that was added in #136. According to https://github.com/actions/checkout/discussions/928#discussioncomment-3861581, the path should not contain the `usr/` part, although for `ssh-add` and `ssh-agent`, it has to.	2022-10-19 14:55:54 +02:00
Oktawian Chojnacki	df2f741a87	Provide `gitPath` for Windows to avoid failures on `windows-2022` (GitHub-hosted runner) (#137 ) ### Problem: Observed error on `windows-2022` ([GitHub-hosted runner](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources)) that `git` command cannot be found. ### Issue: Cannot find git executable on on windows-2022 (GitHub-hosted runner) #136 ### Solution: This path improvement makes use of existing `path.js` to resolve and return correct `git.exe` path for Windows, leaving the executable name as it was for other operating systems. ### Caveats: No idea how and why this `c://progra~1//git//usr//bin//git.exe` mumbo-jumbo works but it apparently did for other executables so figured it should work for `git.exe` (and it does).	2022-10-19 13:27:50 +02:00
Matthias Pigulla	4b6f4eb000	Windows virtual environment: Use SSH binaries from the Git suite (#63 ) * Use SSH binaries from the Git suite * Try to kill the ssh-agent upon action termination on Windows as well	2021-03-10 08:19:17 +01:00

Matthias Pigulla

8a9e20a586

Fix path to git binary on Windows runners (#140 )

This PR fixes an apparently wrong path to the `git` binary that was added in #136. 

According to https://github.com/actions/checkout/discussions/928#discussioncomment-3861581, the path should not contain the `usr/` part, although for `ssh-add` and `ssh-agent`, it has to.

2022-10-19 14:55:54 +02:00

Oktawian Chojnacki

df2f741a87

Provide gitPath for Windows to avoid failures on windows-2022 (GitHub-hosted runner) (#137 )

### Problem:
Observed error on `windows-2022` ([GitHub-hosted runner](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources)) that `git` command cannot be found.

### Issue: 

Cannot find git executable on on windows-2022 (GitHub-hosted runner) #136 

### Solution:
This path improvement makes use of existing `path.js` to resolve and return correct `git.exe` path for Windows, leaving the executable name as it was for other operating systems.

### Caveats:
No idea how and why this `c://progra~1//git//usr//bin//git.exe` mumbo-jumbo works but it apparently did for other executables so figured it should work for `git.exe` (and it does).

2022-10-19 13:27:50 +02:00

Matthias Pigulla

4b6f4eb000

Windows virtual environment: Use SSH binaries from the Git suite (#63 )

* Use SSH binaries from the Git suite

* Try to kill the ssh-agent upon action termination on Windows as well

2021-03-10 08:19:17 +01:00

3 commits