Commit graph

194 commits

Author SHA1 Message Date
Ruud
cf1666fa2c
Merge pull request #171 from EmperorArthur/fix_wall_profile
Update Stacking Lip Profile
2024-04-18 20:07:55 +02:00
Arthur Moore
637b98577f Match radius of bin to radius of base.
Fixes #169, and #165.
2024-03-10 23:34:30 -04:00
Arthur Moore
5b25e2e114 Replace "1.4" constant in profile_wall() with calculated value 2024-03-10 23:28:47 -04:00
Arthur Moore
69cb64e98d Rename chamfered profile to stacking_lip_chamfered() 2024-03-10 23:23:09 -04:00
Arthur Moore
015daff2e8 Update Stacking Lip Profile
Profile is now based on https://gridfinity.xyz/specification/
This does not change the final profile, merely how it is created.

Fixes #168 - Cura watertight issue.
Paritally fixes #169 - FreeCad errors.
2024-02-24 03:57:06 -05:00
Arthur Moore
fd4db5aa9f Add more brief function descriptions 2024-02-24 09:18:49 +01:00
Arthur Moore
6b6b385cda Made height calculations more readable.
There are significantly more lines, but the code is now more understandable.
2024-02-24 09:18:49 +01:00
Priit Laes
5df82679c8 Fix r_fo1 radius to 7.5/2 and fix usage in code
Also introduce d_fo1 = 2 * r_fo1 in places where diameter seems
to be used.
2024-02-16 22:40:01 +01:00
Priit Laes
b4abd1d474 Use proper radius value for r_fo2 2024-02-16 22:40:01 +01:00
Priit Laes
9b364e410c Use proper radius value for r_fo3
The same value used in baseplate is now handled as radius (instead of
diameter).
2024-02-16 22:40:01 +01:00
Asger1002
2f2567d7a9 Removed whitespace in attempt to pass merge test
Pre-merge test showed a failure in removing 'trailing whitespace'. Some whitespaces removed in an attempt to pass this.
2024-02-16 16:15:06 +01:00
Asger1002
1bc283cf59 code cleanup + added comments
- Added comments describing CutEqualBins functionality
- Fixed a single line of missing code as described in a github comment
2024-02-16 16:15:06 +01:00
Asger1002
db06f2914b Added ability to customize tab sizes. Added function for cutting multiple bins.
Additions:
- ability to change height of tab, i.e. stickout, for thinner/thicker labels. Specified in mm.

- ability to change width of tab, for longer/shorter tabs that don't span the full bin width. Specified in mm.

- 'CuEqualBins' function for cutting multiple equally-sized bins given:
* amount of bins (in x and y directions)
* length (in x and y directions, specified in gridfinity-bases),
* starting position (lower left of first bin, in gridfinity bases)
2024-02-16 16:15:06 +01:00
James Jenkins
e31742e37d Make style_hole=4 compatible with only_corners 2024-02-16 12:47:26 +01:00
Timothy Stranex
74d40adb0b Pass chamfer parameter to cutCylinders 2024-02-15 10:25:20 +01:00
Timothy Stranex
d6eb8402e9 Add chamfers to cylindrical cutout holes 2024-02-15 10:25:20 +01:00
Stephen Kent
0fdb10526f Pass style_lip argument in gridfinityInit usages
faff922757 migrated `style_lip` from a
global value to be an argument to `gridfinityInit`, but the usages were
not updated.
2024-02-15 09:53:33 +01:00
Stephen Kent
0b7bf6ee78 Fix clearence -> clearance typo 2024-01-29 09:59:51 +01:00
Stephen Kent
faff922757 Add style_lip as argument to gridfinityInit
When used as a library, `grifinity-rebuilt-utility.scad` accepts all the
bin properties to use as arguments to `gridfinityInit`, `cut`, or other
methods, with the sole exception of `style_lip` which must be defined in
the calling file.

This change adds `style_lip` as an argument to `gridfinityInit` to
ensure `gridfinity-rebuilt-utility.scad` can be used as a library.
2024-01-29 09:58:53 +01:00
Ruud
e7478a7dc9
Merge pull request #128 from smkent/pre-commit
Remove trailing whitespace, add pre-commit and CI workflow to check whitespace
2024-01-06 17:46:32 +01:00
Stephen Kent
944dd39c81 Fix whitespace errors using pre-commit 2024-01-06 08:37:37 -08:00
Stephen Kent
e50dde1aa7 Add --show-diff-on-failure to pre-commit in CI 2024-01-06 08:36:42 -08:00
Ruud
3a485537da
Merge branch 'main' into pre-commit 2024-01-06 13:18:55 +01:00
Lowell Alleman
5e70a29f6f Update index.md
Add a link back to the main github page
2024-01-06 13:13:40 +01:00
Ruud
37389809eb
Merge pull request #138 from jannessm/main
add cylindrical cutouts to *_bins.scad
2024-01-06 02:10:54 +01:00
Brandon Gibbs
7a33233ee9 fix #126 2024-01-06 02:05:36 +01:00
schorsch3000
084f8ed981
Bugfix/fix fixed baseplate offest (#143)
* make the baseplate xy offset configurable

* rename variable to be shorter

---------

Co-authored-by: Dirk Heilig <heilig@adesso-mobile.de>
2024-01-06 02:04:01 +01:00
Stephen Kent
86cab75c50 Merge remote-tracking branch 'origin/main' into pre-commit
Conflicts:
	gridfinity-rebuilt-utility.scad
2023-12-24 15:23:05 -08:00
Jannes
6202c73b21 move cylindrical cutouts to utility 2023-11-21 21:41:08 +01:00
Jannes
2dc165911a Merge branch 'main' of https://github.com/jannessm/gridfinity-rebuilt-openscad 2023-11-21 21:17:59 +01:00
Jannes Magnusson
3324c6b2a7 add spacing for cylinders 2023-11-21 21:17:47 +01:00
Jannes Magnusson
41cdc2a46d add cylindrical cutouts 2023-11-21 21:17:47 +01:00
Ruud
c95938da94
Merge pull request #129 from banpower1:banpower1/gridfinity-refined-holes
Gridfinity Refined magnet holes
2023-11-11 20:39:13 +01:00
Ruud
9592437315
Merge pull request #140 from gpeden:main
fix hole style typo
2023-11-11 11:49:37 +01:00
=
a3598bbe7c fix hole style typo 2023-11-10 22:28:53 -08:00
Jannes Magnusson
a8066f511e
add spacing for cylinders 2023-10-25 20:58:55 +02:00
Ruud
003a6296b1
Merge pull request #127 from smkent/tab-fillet-cutter-no-tabs
Skip tab fillet cutter if tabs are disabled
2023-10-25 15:19:05 +02:00
Jannes Magnusson
a92c740c0d
add cylindrical cutouts 2023-10-23 21:38:02 +02:00
banpower1
b50c07a0fb Added refined_hole function into block_base allowing to select option 4 - Refined holes 2023-09-26 22:54:02 +02:00
Stephen Kent
a7e91ab825 Add Github Actions workflow to run pre-commit 2023-09-21 23:12:21 -07:00
Stephen Kent
046ed3067c Add whitespace fixes generated by pre-commit 2023-09-21 23:11:23 -07:00
Stephen Kent
fc6ead1aef Add pre-commit and configuration 2023-09-21 23:10:50 -07:00
Stephen Kent
19e2a5996b Skip tab fillet cutter if tabs are disabled 2023-09-21 22:16:28 -07:00
Kenneth
a5f5f5b3b7
Update README.md 2023-08-04 21:55:26 -07:00
Ruud
d5c582f537
Merge pull request #120 from rpedde/fix-undefined-length
Fix "unknown variable length" error
2023-06-08 21:16:15 +02:00
rpedde
4ae0a87793 Fix "unknown variable length" error
The "only corners" option didn't get the message about the move of
length to l_grid in 99100b66
2023-06-08 12:01:29 -05:00
Ruud
2fef9f6d70
Merge pull request #89 from Ruudjhuu/hotfix/holes_at_corners
fix holes only on corners
2023-05-31 19:18:33 +02:00
Ruud Swinkels
56ca5e4861 remove hole in middle of baseplate with weighted baseplate 2023-05-31 19:17:27 +02:00
Ruud Swinkels
1622fcbc1d Merge remote-tracking branch 'upstream/main' into hotfix/holes_at_corners 2023-05-31 19:01:00 +02:00
Daniel Manz
f43950bba8
Merge pull request #107 from Ruudjhuu/fix/static_hole_location
fix dynamic hole location on grid length
2023-05-31 18:46:48 +02:00